Skip to content

Conversation

@sebastinas
Copy link
Contributor

It looks like the canonical interface for accessing the MIT HRTF data is via include/hrtf/mit_hrtf.h. So I don't think installing those headers is necessary. Especially when HAVE_MIT_HRTF is set to OFF, they shouldn't be installed.

@jbkempf
Copy link
Collaborator

jbkempf commented Jul 31, 2018

Hmm, I need to check

@jbkempf
Copy link
Collaborator

jbkempf commented Oct 22, 2025

@peterStitt @ePirat opinion here?

@ePirat
Copy link
Collaborator

ePirat commented Oct 23, 2025

I agree, we probably should not install them.

@ePirat ePirat self-assigned this Oct 23, 2025
@peterStitt
Copy link
Contributor

Seems sensible not to install if not needed.

@ePirat
Copy link
Collaborator

ePirat commented Oct 23, 2025

@peterStitt Are these ever needed for library users? Even if someone really needs MIT HRTF data they can already query it with MIT_HRTF::get, is my understanding?

@ePirat
Copy link
Collaborator

ePirat commented Oct 23, 2025

@peterStitt On the topic of headers, it also seems we probably should not install the t_design_5200.h?

@peterStitt
Copy link
Contributor

@peterStitt Are these ever needed for library users? Even if someone really needs MIT HRTF data they can already query it with MIT_HRTF::get, is my understanding?

MIT HRTF is only used internally so I can't see any reason why a library user should ever need any access to them. As you say, MIT_HRTF::get lets them access the HRTF if they need it for something outside libspatialaudio.

@peterStitt On the topic of headers, it also seems we probably should not install the t_design_5200.h?

Yes, no need to install that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants